fix #11522 #11524
fix #11522 #11524
Conversation
Remove php version suffix from '-' separator
|
Warning: socket_sendto(): Unable to write to socket [105]: No buffer space available in /tmp/cirrus-ci-build/ext/sockets/tests/socket_sendto_zerocopy.php on line 25 |
The error you saw is spurious. These can fail when the CI is under high I/O pressure. |
|
I think this looks good. I'm not sure why you closed this, but feel free to reopen if you feel comfortable submitting this. :) |
|
AFAIK it's somewhat discouraged to use dev PHP versions for stub_gen/vm_gen etc, but if that's a rule we should make it explicit in the build script. This looks good to me for now. |
There was a problem hiding this comment.
@iluuu1994 This also reproduces on some distros where the distro suffixes the PHP version, e.g. 7.2.24-0ubuntu0.16.04.16 as in the original report. (It's outdated of course, but it shows the point)
This scenario would break stub generation, so I think we should also backport it to 8.1 & 8.2. WDYT?
|
Ah, I missed that part. Sure, backporting should be fine. |
|
Thank you @SVGAnimate ! |
Remove php version suffix from '-' separator